charts/nginz: Configure rate limits for claiming MLS key packages and getting one2one conversations #3918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
…nd target user When creating a conversation a client needs to get a lot of key packages, each for a different user. If we merely just bump the limit for this endpoint, we will allow for DoS by someone targetting a particular user. So here we rate limit by ensuring that the target user is included in the rate limiting key.
akshaymankar
force-pushed
the
mls-rate-limits
branch
3 times, most recently
from
848712e to
3f33348
Compare
…n/:user During migration from proteus to MLS, this endpoint gets called for every connection. Slowing it down just causes login to take very long.
akshaymankar
force-pushed
the
mls-rate-limits
branch
from
3f33348 to
44d30d7
Compare
elland
approved these changes
Mar 5, 2024
mastaab
approved these changes
Mar 5, 2024
smatting
reviewed
Mar 5, 2024
Merged
2 tasks
mdimjasevic
pushed a commit
that referenced
this pull request
Apr 24, 2024
… getting one2one conversations (#3918)
2 tasks
echoes-hq
bot
added
the
echoes: unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-6979
Checklist
changelog.d