Make federator error logs more informative. #3919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
akshaymankar
requested changes
Mar 5, 2024
| toWai (RemoteErrorResponse _ _ status body) = | ||
| federationRemoteResponseError status body | ||
| toWai (RemoteError target msg err) = | ||
| federationRemoteHTTP2Error (cs $ show (target, msg)) err |
There was a problem hiding this comment.
The error type contains errorData we should use that instead of stringifying everything. If we really want to stringify this, can we use something better than a tuple?
akshaymankar
approved these changes
Mar 5, 2024
fisx
force-pushed
the
fix-federator-error-logs
branch
from
b8ae71f to
7d28958
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-6998
Checklist
changelog.d