Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 4 migrated Helm charts #3927

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Remove 4 migrated Helm charts #3927

merged 5 commits into from
Mar 7, 2024

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Mar 6, 2024 •
edited
Loading

This PR removes migrated Helm Charts

  • webapp
  • team-settings
  • account-pages
  • sftd

https://wearezeta.atlassian.net/browse/WPB-7025

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 6, 2024
@smatting smatting changed the title Remove migrated helm chart Remove 4 migrated Helm Chart Mar 6, 2024
@smatting smatting changed the title Remove 4 migrated Helm Chart Remove 4 migrated Helm charts Mar 6, 2024
@smatting smatting requested a review from akshaymankar March 6, 2024 16:44
akshaymankar
akshaymankar approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think this requires a significant update in docs as they assume that some of these components are part of the wire-server helm chart. I guess docs don't get updated from this branch, so its ok to merge it.

@smatting
Copy link
Contributor Author

smatting commented Mar 7, 2024

I created a follow-up ticket for the documentation https://wearezeta.atlassian.net/browse/WPB-7036

@smatting smatting merged commit 930db54 into q1-2024 Mar 7, 2024
8 checks passed
@smatting smatting deleted the WPB-7025 branch March 7, 2024 08:14
@smatting smatting mentioned this pull request Mar 7, 2024
Merged
2 tasks
mdimjasevic pushed a commit that referenced this pull request Apr 24, 2024
@smatting @mdimjasevic
Remove 4 migrated Helm charts (#3927)
64d53e6
@mdimjasevic mdimjasevic mentioned this pull request Apr 24, 2024
Merged
2 tasks
@zebot zebot mentioned this pull request Apr 25, 2024
Merged
@smatting smatting mentioned this pull request May 28, 2024
Closed
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees
No one assigned
Labels
echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smatting @akshaymankar @zebot