Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smallstep nginx: use resolver to handle offline proxy targets #3946

Conversation

supersven
Copy link
Contributor

@supersven supersven commented Mar 13, 2024

Usually, proxy targets are resolved when nginx is started. This can lead to strange behavior if the target either doesn't exist (yet) or the DNS entry changes while nginx is running.

This little trick with the indirection via a variable should trigger the lookup(s) while nginx is running. The default behavior of the resolver directive is to update the target according to its TTL in the configured DNS server.

Ticket: https://wearezeta.atlassian.net/browse/WPB-6822

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

Usually, proxy targets are resolved when nginx is started. This can lead
to strange behavior if the target either doesn't exist (yet) or the DNS
entry changes while nginx is running.

This little trick with the indirection via a variable should trigger the
lookup(s) while nginx is running. The default behavior of the `resolver`
directive is to update the target according to its TTL in the configured
DNS server.
@supersven supersven changed the base branch from develop to q1-2024 March 13, 2024 10:59
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 13, 2024
@supersven supersven merged commit 09c3084 into q1-2024 Mar 13, 2024
7 checks passed
@supersven supersven deleted the sventennie/q1-2024-use-resolver-to-handle-offline-proxy-targets branch March 13, 2024 12:52
supersven added a commit that referenced this pull request Mar 13, 2024
Usually, proxy targets are resolved when nginx is started. This can lead
to strange behavior if the target either doesn't exist (yet) or the DNS
entry changes while nginx is running.

This little trick with the indirection via a variable should trigger the
lookup(s) while nginx is running. The default behavior of the `resolver`
directive is to update the target according to its TTL in the configured
DNS server.
supersven added a commit that referenced this pull request Mar 14, 2024
Usually, proxy targets are resolved when nginx is started. This can lead
to strange behavior if the target either doesn't exist (yet) or the DNS
entry changes while nginx is running.

This little trick with the indirection via a variable should trigger the
lookup(s) while nginx is running. The default behavior of the `resolver`
directive is to update the target according to its TTL in the configured
DNS server.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants