Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPB 7155 smallstep-accomp CRL-Proxy CORS #3956

Merged
merged 1 commit into from
Mar 14, 2024
Merged

WPB 7155 smallstep-accomp CRL-Proxy CORS #3956

merged 1 commit into from
Mar 14, 2024

Conversation

mastaab
Copy link
Contributor

@mastaab mastaab commented Mar 14, 2024

In order for the CRL-proxy to function correctly, it needs to have CORS headers set.
We are now setting the CORS headers on the ingress level.

@mastaab mastaab requested a review from supersven March 14, 2024 16:34
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 14, 2024
supersven
supersven approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (This is an upstream from q1-2024)

@mastaab mastaab merged commit 479a302 into develop Mar 14, 2024
8 checks passed
@mastaab mastaab deleted the WPB-7155-smallstep-accomp-crl-proxy-cors-develop branch March 14, 2024 18:28
@zebot zebot mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supersven supersven supersven approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mastaab @supersven @zebot