Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

early exit when deleting already gone client #3985

Merged
merged 1 commit into from
Apr 9, 2024
Merged

early exit when deleting already gone client #3985

merged 1 commit into from
Apr 9, 2024

Conversation

stefanwire
Copy link
Contributor

https://wearezeta.atlassian.net/browse/WPB-7416

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@stefanwire
early exit when deleting already gone client
cd25e03 
- in Galley's internal `DELETE /i/client/:clientid`
@stefanwire stefanwire requested a review from supersven April 8, 2024 16:27
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 8, 2024
supersven
supersven approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@supersven supersven mentioned this pull request Apr 9, 2024
Merged
2 tasks
@mdimjasevic
Copy link
Contributor

Can we please avoid debugging efforts in develop? CC: @supersven , @stefanwire

@stefanwire
Copy link
Contributor Author

Can we please avoid debugging efforts in develop? CC: @supersven , @stefanwire

Following the discussion on Backend, I will merge the logs. They should not be viewed as efforts to debug a single issue, but rather seen as an effort to debug future issues on live systems. This should remain in place until we settle on a better way to achieve the same or better observability of our services.

@stefanwire stefanwire merged commit f1c1ea3 into develop Apr 9, 2024
8 checks passed
@stefanwire stefanwire deleted the sb/logeffects-develop branch April 9, 2024 09:12
fisx pushed a commit that referenced this pull request Apr 15, 2024
@stefanwire @fisx
early exit when deleting already gone client (#3985)
7183428 
- in Galley's internal `DELETE /i/client/:clientid`
@zebot zebot mentioned this pull request Apr 25, 2024
Merged
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supersven supersven supersven approved these changes

Assignees
No one assigned
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stefanwire @mdimjasevic @supersven @zebot