Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize getting all feature configs #4002

Merged
merged 29 commits into from
Apr 19, 2024
Merged

Optimize getting all feature configs #4002

merged 29 commits into from
Apr 19, 2024

Conversation

akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented Apr 15, 2024 •
edited by fisx
Loading

https://wearezeta.atlassian.net/browse/WPB-8713

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 15, 2024
@akshaymankar akshaymankar force-pushed the optimize-feature-configs branch from e4cf2c5 to ba73724 Compare April 16, 2024 12:19
@fisx fisx force-pushed the optimize-feature-configs branch from 824a4fe to 8529272 Compare April 17, 2024 14:08
fisx added 3 commits April 19, 2024 12:57
@fisx
lint
c8c7cf8
@fisx
Fixup
46bc398 
(ttl is fuzzy, so it's ok to be off-by-one in the test.)
@fisx
Make TODO a FUTUREWORK.
672ba31 
(this fix is just a hack.  features should be completely remodelled
under a new, incompatible API!)
@fisx fisx marked this pull request as ready for review April 19, 2024 12:47
@fisx fisx merged commit 92be9fc into develop Apr 19, 2024
7 checks passed
@fisx fisx deleted the optimize-feature-configs branch April 19, 2024 14:12
pcapriotti pushed a commit that referenced this pull request Apr 23, 2024
@akshaymankar @battermann
@fisx @pcapriotti
Optimize IO time for getting all feature configs (#4002)
b94aea3 
Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>
@zebot zebot mentioned this pull request Apr 25, 2024
Merged
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jun 27, 2024
akshaymankar added a commit that referenced this pull request Aug 5, 2024
@akshaymankar @battermann @fisx
Backport #4002
e9be6a1 
Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>
akshaymankar added a commit that referenced this pull request Aug 5, 2024
@akshaymankar
Partially Backport #4051
34383c8 
Some of it was undone in #4070 because #4002 was not yet backported
akshaymankar added a commit that referenced this pull request Aug 6, 2024
@akshaymankar
Partially Backport #4051
f0e9248 
Some of it was undone in #4070 because #4002 was not yet backported
akshaymankar added a commit that referenced this pull request Aug 6, 2024
@akshaymankar @battermann @fisx
Backport #4002 (#4184)
75fe742 
* Backport #4002

Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>

* Partially Backport #4051

Some of it was undone in #4070 because #4002 was not yet backported

---------

Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elland elland elland left review comments

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akshaymankar @elland @fisx @zebot @battermann