-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WPB-9065] Stop supporting phone numbers in supported client API versions #4045
Merged
mdimjasevic
merged 47 commits into
develop
from
wpb-9065/stop-support-phone-numbers-v0-v5
Jul 3, 2024
Merged
[WPB-9065] Stop supporting phone numbers in supported client API versions #4045
mdimjasevic
merged 47 commits into
develop
from
wpb-9065/stop-support-phone-numbers-v0-v5
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
label
May 9, 2024
mdimjasevic
force-pushed
the
wpb-9065/stop-support-phone-numbers-v0-v5
branch
10 times, most recently
from
May 15, 2024 11:12
f8ce0ec
to
43fb173
Compare
Quality Gate passedIssues Measures |
mdimjasevic
force-pushed
the
wpb-9065/stop-support-phone-numbers-v0-v5
branch
from
June 3, 2024 08:10
67659ae
to
2f6a534
Compare
pcapriotti
force-pushed
the
wpb-9065/stop-support-phone-numbers-v0-v5
branch
2 times, most recently
from
June 5, 2024 12:18
b31240f
to
7363a94
Compare
mdimjasevic
changed the title
[WPB-9065] Stop supporting phone numbers in supported client API versions
[DO NOT MERGE] [WPB-9065] Stop supporting phone numbers in supported client API versions
Jun 5, 2024
mdimjasevic
force-pushed
the
wpb-9065/stop-support-phone-numbers-v0-v5
branch
2 times, most recently
from
June 6, 2024 13:46
7ee6948
to
da929a6
Compare
pcapriotti
force-pushed
the
wpb-9065/stop-support-phone-numbers-v0-v5
branch
from
June 10, 2024 11:48
81363bb
to
ad7deda
Compare
mdimjasevic
force-pushed
the
wpb-9065/stop-support-phone-numbers-v0-v5
branch
4 times, most recently
from
June 11, 2024 08:12
3ccb73c
to
5d91cf9
Compare
mdimjasevic
commented
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started the PR so I can't approve it.
It all looks good to me.
mdimjasevic
force-pushed
the
wpb-9065/stop-support-phone-numbers-v0-v5
branch
from
June 11, 2024 08:30
d55fadb
to
1a65447
Compare
pcapriotti
approved these changes
Jun 13, 2024
mdimjasevic
force-pushed
the
wpb-9065/stop-support-phone-numbers-v0-v5
branch
3 times, most recently
from
June 13, 2024 12:15
8abad2e
to
48cd35d
Compare
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
More specific category, to highlight Technical Debt being tackled.
label
Jun 27, 2024
mdimjasevic
force-pushed
the
wpb-9065/stop-support-phone-numbers-v0-v5
branch
from
July 3, 2024 09:27
a891227
to
13581a7
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some golden tests have changed because support for phone-based account registration and activation has been disabled. The failure happens not when parsing a request body with a phone number, but rather at the endpoint handler level.
Twilio and Nexmo libraries have been dropped as they're dead code now.
Tracked by https://wearezeta.atlassian.net/browse/WPB-9065.
Checklist
changelog.d
docs/src/developer/reference/user/activation.md
should be modifiedWire.API.User.User
) that have a phone number in their identity (userIdentity
) to JSONfail "error-code"
and then changing the response in the middleware