Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPB-9065] Stop supporting phone numbers in supported client API versions #4045

Merged
merged 47 commits into from
Jul 3, 2024

Conversation

mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented May 9, 2024

Some golden tests have changed because support for phone-based account registration and activation has been disabled. The failure happens not when parsing a request body with a phone number, but rather at the endpoint handler level.

Twilio and Nexmo libraries have been dropped as they're dead code now.

Tracked by https://wearezeta.atlassian.net/browse/WPB-9065.

Checklist

  • Grep "or phone" in the documentation and drop them
  • Change the Stern API so that anything phone-related is removed
  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines
  • See if the "Phone/email whitelist" section of docs/src/developer/reference/user/activation.md should be modified
  • Have golden tests for serializing users (Wire.API.User.User) that have a phone number in their identity (userIdentity) to JSON
  • Check if there's an integration test for getting an activation code via email
  • Fix unholy thing, i.e., using fail "error-code" and then changing the response in the middleware

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label May 9, 2024
@mdimjasevic mdimjasevic force-pushed the wpb-9065/stop-support-phone-numbers-v0-v5 branch 10 times, most recently from f8ce0ec to 43fb173 Compare May 15, 2024 11:12
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mdimjasevic mdimjasevic force-pushed the wpb-9065/stop-support-phone-numbers-v0-v5 branch from 67659ae to 2f6a534 Compare June 3, 2024 08:10
@pcapriotti pcapriotti force-pushed the wpb-9065/stop-support-phone-numbers-v0-v5 branch 2 times, most recently from b31240f to 7363a94 Compare June 5, 2024 12:18
@mdimjasevic mdimjasevic changed the title [WPB-9065] Stop supporting phone numbers in supported client API versions [DO NOT MERGE] [WPB-9065] Stop supporting phone numbers in supported client API versions Jun 5, 2024
@mdimjasevic mdimjasevic force-pushed the wpb-9065/stop-support-phone-numbers-v0-v5 branch 2 times, most recently from 7ee6948 to da929a6 Compare June 6, 2024 13:46
@pcapriotti pcapriotti force-pushed the wpb-9065/stop-support-phone-numbers-v0-v5 branch from 81363bb to ad7deda Compare June 10, 2024 11:48
@mdimjasevic mdimjasevic force-pushed the wpb-9065/stop-support-phone-numbers-v0-v5 branch 4 times, most recently from 3ccb73c to 5d91cf9 Compare June 11, 2024 08:12
Copy link
Contributor Author

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started the PR so I can't approve it.

It all looks good to me.

@mdimjasevic mdimjasevic force-pushed the wpb-9065/stop-support-phone-numbers-v0-v5 branch from d55fadb to 1a65447 Compare June 11, 2024 08:30
@mdimjasevic mdimjasevic force-pushed the wpb-9065/stop-support-phone-numbers-v0-v5 branch 3 times, most recently from 8abad2e to 48cd35d Compare June 13, 2024 12:15
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Jun 27, 2024
@mdimjasevic mdimjasevic force-pushed the wpb-9065/stop-support-phone-numbers-v0-v5 branch from a891227 to 13581a7 Compare July 3, 2024 09:27
@mdimjasevic mdimjasevic merged commit d1f4b1f into develop Jul 3, 2024
10 checks passed
@mdimjasevic mdimjasevic deleted the wpb-9065/stop-support-phone-numbers-v0-v5 branch July 3, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants