Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPB-7161] Fix Request ID logging in all services #4059

Merged
merged 41 commits into from
May 30, 2024

Conversation

mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented May 22, 2024

The request ID was being generated as the first middleware, which doesn't allow subsequently applied middlewares to log correctly as they don't get the modified request.

In federator this was complicated by the fact that the request ID middlware was absent and the endpoints explicitly expected the request ID header causing errors from the catchErrors middleware to never get the request id. In addition the interpreter for polysemy effects was being passed inside and it tried to read the request ID from the Env which didn't have the right request ID. This is all refactored to be similar to other services where a middleware ensures that the request contains a request id and other parts just rely on the request to get this request id.

Tracked by https://wearezeta.atlassian.net/browse/WPB-7161.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label May 22, 2024
@mdimjasevic mdimjasevic force-pushed the clean-up-request-id branch from e1c4df1 to 60abca1 Compare May 22, 2024 11:51
@battermann battermann force-pushed the clean-up-request-id branch from af29e3f to 117efbd Compare May 22, 2024 14:10
@akshaymankar akshaymankar force-pushed the clean-up-request-id branch from dd388f3 to edb5031 Compare May 29, 2024 08:23
@akshaymankar akshaymankar changed the title [WPB-7161] Include a request ID header [WPB-7161] Fix Request ID logging in all services May 29, 2024
@akshaymankar akshaymankar marked this pull request as ready for review May 29, 2024 11:07
.hlint.yaml Outdated Show resolved Hide resolved
@stefanwire stefanwire force-pushed the clean-up-request-id branch from e0ad210 to f8e2637 Compare May 30, 2024 08:36
@stefanwire stefanwire merged commit 1bff352 into develop May 30, 2024
9 checks passed
@stefanwire stefanwire deleted the clean-up-request-id branch May 30, 2024 09:52
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants