-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WPB-7161] Fix Request ID logging in all services #4059
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
label
May 22, 2024
mdimjasevic
force-pushed
the
clean-up-request-id
branch
from
May 22, 2024 11:51
e1c4df1
to
60abca1
Compare
battermann
force-pushed
the
clean-up-request-id
branch
from
May 22, 2024 14:10
af29e3f
to
117efbd
Compare
akshaymankar
force-pushed
the
clean-up-request-id
branch
from
May 29, 2024 08:23
dd388f3
to
edb5031
Compare
akshaymankar
changed the title
[WPB-7161] Include a request ID header
[WPB-7161] Fix Request ID logging in all services
May 29, 2024
stefanwire
approved these changes
May 29, 2024
…other middlewares use it
It is explicit that the server doesn't stop until the response gets consumed
It gets used as an `Input` directly
Delete unused runWaiError function and its tests. The tests were actually testing AsWai instances of various errors, but they seem trivial enough to not require tests.
stefanwire
force-pushed
the
clean-up-request-id
branch
from
May 30, 2024 08:36
e0ad210
to
f8e2637
Compare
echoes-hq
bot
added
the
echoes: unplanned
Any work item that isn’t part of the product or technical roadmap.
label
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: unplanned
Any work item that isn’t part of the product or technical roadmap.
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request ID was being generated as the first middleware, which doesn't allow subsequently applied middlewares to log correctly as they don't get the modified request.
In federator this was complicated by the fact that the request ID middlware was absent and the endpoints explicitly expected the request ID header causing errors from the catchErrors middleware to never get the request id. In addition the interpreter for polysemy effects was being passed inside and it tried to read the request ID from the
Env
which didn't have the right request ID. This is all refactored to be similar to other services where a middleware ensures that the request contains a request id and other parts just rely on the request to get this request id.Tracked by https://wearezeta.atlassian.net/browse/WPB-7161.
Checklist
changelog.d