dockerephemeral environment: give ES an http interface (needed for old brig) #4062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
fisx
commented
May 24, 2024
| # that. | ||
| # | ||
| # see also: git grep -Hn 'elasticsearch:' ../../brig.yaml | ||
| listen 9201; |
There was a problem hiding this comment.
wait. are we even running an nginz for federation-v0 here? docker-compose ps says no, which makes sense. so maybe we need to run an nginz just so we don't need to run a second ES instance that speaks http?
There was a problem hiding this comment.
Yes, we are running nginz.
| @@ -11,7 +11,7 @@ cassandra: | |||
|
|
|||
| elasticsearch: | |||
| # FUTUREWORK: use separate ES v0 instance | |||
| url: http://elastic:changeme@demo_wire_elasticsearch:9200 | |||
| url: http://127.0.0.1:9201/ | |||
There was a problem hiding this comment.
Suggested change
| url: http://127.0.0.1:9201/ | |
| url: http://demo_wire_nginz:9201/ |
? or what's nginz's name here?
There was a problem hiding this comment.
It's nginz-federation-v0.
pcapriotti
force-pushed
the
pcapriotti/elasticsearch
branch
from
78edf5f to
f840932
Compare
akshaymankar
approved these changes
Jun 4, 2024
| @@ -11,7 +11,7 @@ cassandra: | |||
|
|
|||
| elasticsearch: | |||
| # FUTUREWORK: use separate ES v0 instance | |||
There was a problem hiding this comment.
I guess we don't need this anymore.
fisx
commented
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-9000
Checklist
changelog.d