coturn: Add IP configuration options #4083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
smatting
changed the title
supersven
reviewed
Jun 14, 2024
| # If you need to specify which IP Coturn should bind to. | ||
| # This will typically be the IP of the kubenode. | ||
| # coturnTurnListenIP: "182.168.22.133" | ||
| # coturnTurnListenIP: "1.2.3.4" # can also be __COTURN_EXT_IP__, __COTURN_POD_IP__,__COTURN_HOST_IP__ |
There was a problem hiding this comment.
Some comment explaining the difference between ...ListenIp, ...RelayIp and ...ExternalIp would be helpful.
There was a problem hiding this comment.
Wouldn't that just reproduce the docs fo coturn?
There was a problem hiding this comment.
Yes, but IMHO otherwise admins would need to understand coturn itself and not just look at our Helm charts. 🤔
supersven
reviewed
Jun 14, 2024
supersven
approved these changes
Jun 21, 2024
smatting
added a commit
that referenced
this pull request
Jun 25, 2024
2 tasks
smatting
added a commit
that referenced
this pull request
Jun 25, 2024
echoes-hq
bot
added
the
echoes: product-roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds configuration options in the
coturnhelm chart for settingsrelay-ipexternal-ipprometheus-ipfederation-listening-ipIt also adds a
__COTURN_HOST_IP__template variable which will be substitued by the host ip of thek8snode that is running coturn.This PR is backwards-compatible to
values.yamlfiles written for version of this helm charts without this PR: new variables have defaults that match their previous hardcoded value.Checklist
changelog.d