WPB 2690 #4098
Merged
WPB 2690 #4098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
jschaul
approved these changes
Jun 20, 2024
smatting
commented
Jun 20, 2024
Comment on lines
+29
to
+30
| pidfile="/var/tmp/turnserver.pid" | ||
|
|
There was a problem hiding this comment.
This was added only to prevent a warning
smatting
commented
Jun 20, 2024
Comment on lines
+130
to
+131
| - /usr/bin/dumb-init | ||
| - -- |
There was a problem hiding this comment.
We don't strictly know if this is needed, but we've seen that processes linger around after pod is killed, but weren't able to reproduce. Having an init gives additional guarantees and should prevent subprocesses from remaining after the main process has been killed.
There was a problem hiding this comment.
(were not able to reproduce - or actually didn't spend the time to try out the real previous configuration to reproduce it)
mastaab
added
the
echoes: product-roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
charts/coturn: support putting coturn into 'drain' mode when terminating pods, denying new incoming client connections. This speeds up graceful coturn restarts significantly. See related PR wireapp/coturn#15 and wireapp/coturn#12
drive-by fixes:
Checklist
changelog.d