Fix repeated with-rtsopts option #4118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GHC does not support repeated `--with-rtsopts` options, and it simply applies the last one. This means many of the baked-in options were actually not being passed, including `-N` for some of the services and `-T` for cannon.
zebot
added
the
ok-to-test
akshaymankar
reviewed
Jul 2, 2024
services/federator/federator.cabal
Outdated
Comment on lines
208
to
209
| -threaded "-with-rtsopts=-N1 -T" -rtsopts -Wredundant-constraints | ||
| -Wunused-packages |
There was a problem hiding this comment.
I wonder why we specify -N1 here:
- Its the default anyway
- What's the reason behind this, perhaps would be good to document. Seems to have been added without any specified reason: 47684fe
There was a problem hiding this comment.
seems like it had been N1 as a default when history started in 2017.
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHC does not support repeated
--with-rtsoptsoptions, and it simply applies the last one. This means many of the baked-in options were actually not being passed, including-Nfor some of the services and-Tfor cannon.Checklist
changelog.d