[fix] API version check comes before method check #4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
pcapriotti
approved these changes
Jul 15, 2024
elland
approved these changes
Jul 15, 2024
mdimjasevic
force-pushed
the
battermann/fix-api-version-check
branch
from
b28a259 to
7dc3048
Compare
|
Federation tests were failing in the CI and I suppose for no good reason. I used the opportunity to rebase the PR on top of |
echoes-hq
bot
added
the
echoes: unplanned
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the API version check is done via a version header and servant's order of checks while resolving the routes is fixed. E.g. it can happen that an endpoint with the same path, but different method matches the request even if it has a different version, and then fails with 405 instead of 404.
This change is a hack to enforce the version check to come first.