Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One to one SFT feature flag config #4164

Merged
merged 43 commits into from
Aug 5, 2024
Merged

One to one SFT feature flag config #4164

merged 43 commits into from
Aug 5, 2024

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Jul 22, 2024 •
edited
Loading

This adds a config field to the conferenceCalling flag. It also reorganises the way flags are fetched from the database, so that the logic for computing default values is shared between the code for fetching all features and the code for fetching a single one.

https://wearezeta.atlassian.net/browse/WPB-10235

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 22, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 22, 2024
@elland elland force-pushed the pcapriotti/one-to-one-sft branch from fa82f48 to b3645b4 Compare July 22, 2024 13:25
@pcapriotti pcapriotti marked this pull request as ready for review July 23, 2024 08:27
@pcapriotti pcapriotti force-pushed the pcapriotti/one-to-one-sft branch from 93e7c67 to 275a671 Compare July 24, 2024 06:34
@pcapriotti pcapriotti force-pushed the pcapriotti/one-to-one-sft branch 4 times, most recently from abeac98 to 2f729f7 Compare July 26, 2024 14:14
fisx
fisx previously requested changes Jul 27, 2024
View reviewed changes
cassandra-schema.cql Outdated Show resolved Hide resolved
integration/test/API/BrigInternal.hs Show resolved Hide resolved
libs/wire-api/src/Wire/API/Team/Feature.hs Show resolved Hide resolved
services/brig/src/Brig/Calling/API.hs Show resolved Hide resolved
services/galley/src/Galley/Cassandra/GetAllTeamFeatureConfigs.hs Outdated Show resolved Hide resolved
libs/wire-api/src/Wire/API/Team/Feature.hs Outdated Show resolved Hide resolved
integration/test/Test/FeatureFlags/User.hs Outdated Show resolved Hide resolved
integration/test/Test/FeatureFlags/User.hs Show resolved Hide resolved
libs/wire-api/src/Wire/API/Team/Feature.hs Show resolved Hide resolved
libs/wire-api/src/Wire/API/Team/Feature.hs Show resolved Hide resolved
pcapriotti and others added 19 commits July 31, 2024 10:52
@pcapriotti
Restore weeded-out wsPatch
2ef27b5
@pcapriotti
Add field to ConferenceCallingConfig
cd59a39
@pcapriotti
Use patch endpoint to set feature status in stern
021cdfd
@pcapriotti
Remove FeatureTrivialConfig class
42020fa
@pcapriotti
Add migration to add conference calling sft flag
b0da923
@pcapriotti
Implement get/set conference calling feature flag
ee0f55d
@pcapriotti
Fix golden tests
d701da5
@elland @pcapriotti
Add endpoint to put ConferenceCallingConfig.
b7f2ea1
@elland @pcapriotti
Added lock status to conf. calling.
40f18d9 
WIP: Tests need fixing sinnce it's no longer a SimpleFlag.
@pcapriotti
Fix golden test cases
33ed08e
@pcapriotti
Update conference call ttl test
74a425d
@pcapriotti
Fix conference calling patch test
df96f2d
@pcapriotti
Update CHANGELOG entry
694ce7c
@pcapriotti
Fix assertions in conferenceCalling TTL test
64f0d3c
@pcapriotti
Move user feature test to integration
74c4724 
Also remove its dependency on Cassandra, simplify logic and expand its
scope to include team users.
@pcapriotti
Remove dead code
2fd5dbe
@pcapriotti
Update cassandra schema file
6451292
@pcapriotti
Change how conferenceCalling is stored and loaded
4405f15
@pcapriotti
Add general AllFeatures for any type constructor
c25f044
@pcapriotti pcapriotti force-pushed the pcapriotti/one-to-one-sft branch from 4af90ec to b49dfac Compare July 31, 2024 08:52
@pcapriotti pcapriotti force-pushed the pcapriotti/one-to-one-sft branch from b49dfac to 9c705f9 Compare July 31, 2024 11:56
@pcapriotti
Make lockStatus field optional in galley's conf
4b5d140 
It used to be implicit before, now it is a normal flag, so we need to
make this field optional to preserve compatibility with older
configuration files.
@pcapriotti
Remove unused ToJSON instance
6f49b90
@pcapriotti pcapriotti force-pushed the pcapriotti/one-to-one-sft branch from 0f16468 to 6f49b90 Compare July 31, 2024 13:50
@pcapriotti pcapriotti mentioned this pull request Aug 1, 2024
Merged
2 tasks
@pcapriotti pcapriotti requested a review from fisx August 1, 2024 07:25
@pcapriotti pcapriotti force-pushed the pcapriotti/one-to-one-sft branch from 84e0e0a to 8eda399 Compare August 1, 2024 09:01
@pcapriotti
Fix stern integration tests
515a6b3
@pcapriotti
Update cassandra schema
6c6c133
@pcapriotti
Use bindResponse in tests
7899f01
@pcapriotti
Revert default lock status when parsing feature
5f3cdc2 
Instead of hardcoding an unlocked status when parsing the
conferenceCalling default configuration, set the default in the helm
chart.
@fisx fisx dismissed their stale review August 5, 2024 09:38

you guys handle it!

akshaymankar
akshaymankar approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pcapriotti pcapriotti merged commit 1e97149 into develop Aug 5, 2024
10 checks passed
@pcapriotti pcapriotti deleted the pcapriotti/one-to-one-sft branch August 5, 2024 11:48
akshaymankar pushed a commit that referenced this pull request Aug 5, 2024
@pcapriotti @akshaymankar
Backport #4164
9c85b9e
akshaymankar pushed a commit that referenced this pull request Aug 6, 2024
@pcapriotti @akshaymankar
Backport #4164
703176c
akshaymankar pushed a commit that referenced this pull request Aug 8, 2024
@pcapriotti @akshaymankar
Backport #4164
0a976b4
akshaymankar pushed a commit that referenced this pull request Aug 8, 2024
@pcapriotti @akshaymankar
Backport #4164
2cb9728
akshaymankar added a commit that referenced this pull request Aug 8, 2024
@akshaymankar @pcapriotti
Backport #4164 (#4186)
4d505e0 
Co-authored-by: Paolo Capriotti <paolo@capriotti.io>
@zebot zebot mentioned this pull request Oct 9, 2024
Closed
This was referenced Oct 23, 2024
Closed
Closed
@zebot zebot mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

@elland elland elland approved these changes

@fisx fisx Awaiting requested review from fisx

Assignees
No one assigned
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pcapriotti @elland @akshaymankar @fisx @zebot