Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial MLS configuration for new teams #4262

Merged
merged 8 commits into from
Oct 1, 2024
Merged

Initial MLS configuration for new teams #4262

merged 8 commits into from
Oct 1, 2024

Conversation

pcapriotti
Copy link
Contributor

Add initialConfig setting for the mls feature flag. This is used to initialise MLS configuration values for new teams.

https://wearezeta.atlassian.net/browse/WPB-10795

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud label Sep 23, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 23, 2024
fisx
fisx approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm willing to bet we'll have to do this soon for another team feature. I don't think we should build an abstraction for that, but I sure hope when that happens we'll remember that it has been done before... :)

docs/src/developer/reference/config-options.md Show resolved Hide resolved
integration/integration.cabal Show resolved Hide resolved
integration/test/Test/FeatureFlags/Initialisation.hs Show resolved Hide resolved
services/galley/src/Galley/API/Teams.hs Show resolved Hide resolved
fisx
fisx approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM still :)

@pcapriotti pcapriotti merged commit 433cc0d into develop Oct 1, 2024
10 checks passed
@pcapriotti pcapriotti deleted the new-teams-mls branch October 1, 2024 08:05
@zebot zebot mentioned this pull request Oct 9, 2024
Closed
This was referenced Oct 23, 2024
Closed
Closed
@zebot zebot mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcapriotti @fisx @zebot