Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gundeck: Remove bulkPush config option #4290

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

akshaymankar
Copy link
Member

It has been set to true for a few years now and seems to work well. It is being removed to reduce work for RabbitMq based notifications.

Related: #4272
Also: https://wearezeta.atlassian.net/browse/WPB-10308

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes/initiative: scale Enterprise Readiness Initiatives label Oct 9, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 9, 2024
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

It has been set to `true` for a few years now and seems to work well. It is
being removed to reduce work for RabbitMq based notifications.

Related: #4272
Also: https://wearezeta.atlassian.net/browse/WPB-10308
@akshaymankar akshaymankar force-pushed the wpb-10308/gundeck-only-bulk-push branch from 95a0337 to 5dad114 Compare October 10, 2024 06:11
@akshaymankar akshaymankar merged commit 2f5d10e into develop Oct 10, 2024
10 checks passed
@akshaymankar akshaymankar deleted the wpb-10308/gundeck-only-bulk-push branch October 10, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: scale Enterprise Readiness Initiatives ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants