Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Allow configuring argon2id parameters #4291

Merged
merged 52 commits into from
Oct 21, 2024
Merged
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
1c80e2b
Removed wrong comment.
elland Oct 9, 2024
815481e
Thread password hashing options through the env.
elland Oct 10, 2024
6cd9fb4
Renamed make cmd to avoid accidentally cleaning the whole thing.
elland Oct 10, 2024
1419f59
Cleaning up.
elland Oct 10, 2024
50de042
Clean up from review
elland Oct 10, 2024
0277ca6
Update libs/wire-subsystems/test/unit/Wire/MockInterpreters/HashPassw…
elland Oct 10, 2024
c100cb6
Restore necessary reauth logic
elland Oct 10, 2024
448d81a
Added a changelog.
elland Oct 10, 2024
bd0a1a7
Add docs, beef up changelog entrie(s).
fisx Oct 11, 2024
bfe5384
Fix: default parameters.
fisx Oct 11, 2024
80c2964
Merge remote-tracking branch 'origin/develop' into configurable-argon
fisx Oct 11, 2024
44b726b
Fix: do not take a Nothing for options when hashing passwords!
fisx Oct 11, 2024
42a0dcb
cp info from changelog to docs.
fisx Oct 11, 2024
1f4d18e
Fixed typo.
elland Oct 14, 2024
5ab90fe
Update changelog.d/2-features/add-config-for-pwd-hash
fisx Oct 14, 2024
4083a34
Fix: remove one more spurious call to scrypt.
fisx Oct 14, 2024
c9aab24
wip: Test new params for CI
elland Oct 14, 2024
85a9e03
Change the right place
elland Oct 14, 2024
7154034
Merge remote-tracking branch 'origin/develop' into configurable-argon
elland Oct 14, 2024
d678d9b
Fix/Add more tests for ssoLogin.
elland Oct 14, 2024
9679e00
Make argon2id also fast in local integration tests.
fisx Oct 14, 2024
54d2912
mv argon2id dummy settings from prod to CI.
fisx Oct 14, 2024
62a352b
Restore Missing Auth error.
elland Oct 15, 2024
09ca3d2
Update changelog.d/2-features/add-config-for-pwd-hash
fisx Oct 15, 2024
b04b685
Update docs/src/developer/reference/config-options.md
fisx Oct 15, 2024
3846046
Fixed new test expectation.
elland Oct 15, 2024
73da097
Added logging for the hash opts.
elland Oct 15, 2024
ba549eb
Log also for reg user creation.
elland Oct 15, 2024
dd891b3
More aggressive logging.
elland Oct 15, 2024
ab4fea8
charts/brig: Allow configuring password hashing options
elland Oct 16, 2024
16723dc
hack/helm_vars: Optimize password hashing options so tests run fast
elland Oct 16, 2024
d2ccad4
charts/brig: Set defaults for PasswordHashingOptions
elland Oct 16, 2024
cff50f7
wire-{api,subsystems}: Simplify password hashing options
elland Oct 16, 2024
e0fa88d
brig: Adapt for simplified password hashing options
elland Oct 16, 2024
a3d5bfe
galley: Allow configuring password hashing options
elland Oct 16, 2024
ec11876
hack/helm_var: Configure password hashing options for galley
elland Oct 16, 2024
5ff3b18
brig: Removed debug logging
elland Oct 16, 2024
50c6685
Lint out redundant language pragma.
elland Oct 16, 2024
721e2ff
Update changelog and docs for galley and brig
elland Oct 16, 2024
dc7f299
Lint+
elland Oct 16, 2024
e256d56
galley: Local integration config missing.
elland Oct 17, 2024
d73113c
wip: Fix authentication not handling errors correctly for decrementing
elland Oct 17, 2024
e614940
Clean up and adjust error mapping.
elland Oct 21, 2024
28252fb
Fix SSO login allowing non-sso users to authenticate.
elland Oct 21, 2024
6caaa71
Merge remote-tracking branch 'origin/develop' into configurable-argon
elland Oct 21, 2024
ef29067
hi ci
elland Oct 21, 2024
81e6c2f
Removed stale comments.
elland Oct 21, 2024
9e732e6
Improve in-place comments for auth/reauth/sso flow.
elland Oct 21, 2024
9940aaf
Makefile: fix full-clean.
elland Oct 21, 2024
49183a4
Removed unnecessary type wrangling.
elland Oct 21, 2024
715bf98
Update libs/wire-subsystems/src/Wire/AuthenticationSubsystem/Interpre…
fisx Oct 21, 2024
efe3415
Merge remote-tracking branch 'origin/develop' into configurable-argon
fisx Oct 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/brig/src/Brig/Data/User.hs
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ newAccount u inv tid mbHandle = do
_ <-
liftSem $
Log.warn $
msg (val $ "New account with hash opts: " <> (BS.pack . show $ env.settings.passwordHashingOptions))
fisx marked this conversation as resolved.
Show resolved Hide resolved
msg (val $ "New account with hash opts: " <> (BS.pack . show $ env.settings))
passwd <- maybe (pure Nothing) (fmap Just . liftSem . hashPassword8) pass
expiry <- case status of
Ephemeral -> do
Expand Down
Loading