block access to assets.*/minio/ path #4297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
amitsagtani97
changed the title
| pathType: Prefix | ||
| {{- end }} | ||
| backend: | ||
| {{- if $apiIsStable }} |
There was a problem hiding this comment.
Do we really need this "API is stable"? what's it keying on?
There was a problem hiding this comment.
I am not sure how this variable is configured or used.
But wanted to have same set of conditions here as in the ingress.yaml file
There was a problem hiding this comment.
this var is needed to support the older version of the Kubernetes, because 1.18 and older versions do not support networking.k8s.io/v1 API
julialongtin
approved these changes
Oct 31, 2024
echoes-hq
bot
added
the
echoes: technical-roadmap/security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-11791
Checklist
changelog.d