Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WPB-12098] add inviter email to in-game invitation #4332

Merged
merged 21 commits into from
Nov 8, 2024
Merged

[WPB-12098] add inviter email to in-game invitation #4332

merged 21 commits into from
Nov 8, 2024

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Nov 5, 2024 •
edited by battermann
Loading

https://wearezeta.atlassian.net/browse/WPB-12098

Checklist

  • Document API change in confluence
  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Nov 5, 2024
@fisx fisx force-pushed the WPB-12098-add-inviter-email-to-in-game-invitation branch from e5268a8 to a6099e8 Compare November 6, 2024 15:19
@fisx fisx changed the title [WPB-12098] add inviter email to in game invitation [WPB-12098] add inviter email to in-game invitation Nov 6, 2024
@mdimjasevic mdimjasevic force-pushed the WPB-12098-add-inviter-email-to-in-game-invitation branch from 3fabc09 to 0287955 Compare November 7, 2024 14:00
@battermann battermann marked this pull request as ready for review November 7, 2024 16:15
supersven
supersven reviewed Nov 7, 2024
View reviewed changes
libs/wire-api/src/Wire/API/Team/Invitation.hs Outdated Show resolved Hide resolved
libs/wire-api/src/Wire/API/Team/Invitation.hs Outdated Show resolved Hide resolved
libs/wire-subsystems/src/Wire/TeamInvitationSubsystem/Interpreter.hs Outdated Show resolved Hide resolved
libs/wire-subsystems/src/Wire/TeamInvitationSubsystem/Interpreter.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/Team/API.hs Outdated Show resolved Hide resolved
integration/test/Test/Teams.hs Show resolved Hide resolved
@battermann battermann requested a review from supersven November 8, 2024 09:42
supersven
supersven approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@supersven supersven left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As all my nitpicks are resolved: LGTM 👍

Let's hope ( 🤞 ) that the CI runs green.

@battermann battermann changed the title [WPB-12098] add inviter email to in-game invitation [WPB-12098] add inviter email to personal user invitation Nov 8, 2024
@battermann battermann merged commit 97cf75c into develop Nov 8, 2024
10 checks passed
@battermann battermann deleted the WPB-12098-add-inviter-email-to-in-game-invitation branch November 8, 2024 13:52
@e-maad e-maad mentioned this pull request Nov 11, 2024
Merged
4 tasks
@fisx fisx changed the title [WPB-12098] add inviter email to personal user invitation [WPB-12098] add inviter email to in-game invitation Nov 26, 2024
@zebot zebot mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@battermann battermann battermann left review comments

@supersven supersven supersven approved these changes

Assignees
No one assigned
Labels
echoes/initiative: personal-users-to-team-users... ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fisx @battermann @supersven @zebot