-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WPB-15037] fix flaky test migration to new index #4382
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
label
Dec 18, 2024
As this is only used in tests, it makes sense to keep both indices up-to-date.
fisx
approved these changes
Dec 18, 2024
fisx
changed the title
fix flaky test migration to new index
[WPB-15037] fix flaky test migration to new index
Dec 18, 2024
echoes-hq
bot
added
the
echoes: technical-roadmap/security
More specific category, to highlight task that tackle security requirements.
label
Dec 18, 2024
The index migrations need access to both ES indices. This cannot be provided by a proxy which is configured to serve only for one index.indices This commit needs cleanup. Committing it to save the result.
supersven
force-pushed
the
sventennie/fix-flaky-testMigrationToNewIndex
branch
from
December 18, 2024 18:59
1627c92
to
0ef8108
Compare
This will set it under test.
(Instead of talking to ES here directly.)
fisx
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: technical-roadmap/security
More specific category, to highlight task that tackle security requirements.
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-15037
Checklist
changelog.d