Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPB-15037] fix flaky test migration to new index #4382

Merged
merged 16 commits into from
Dec 19, 2024

Conversation

supersven
Copy link
Contributor

@supersven supersven commented Dec 18, 2024

https://wearezeta.atlassian.net/browse/WPB-15037

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Dec 18, 2024
fisx and others added 2 commits December 18, 2024 15:53
As this is only used in tests, it makes sense to keep both indices
up-to-date.
@fisx fisx marked this pull request as ready for review December 18, 2024 15:08
@fisx fisx changed the title fix flaky test migration to new index [WPB-15037] fix flaky test migration to new index Dec 18, 2024
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. label Dec 18, 2024
fisx and others added 2 commits December 18, 2024 18:34
The index migrations need access to both ES indices. This cannot be
provided by a proxy which is configured to serve only for one index.indices

This commit needs cleanup. Committing it to save the result.
@supersven supersven force-pushed the sventennie/fix-flaky-testMigrationToNewIndex branch from 1627c92 to 0ef8108 Compare December 18, 2024 18:59
@fisx
Copy link
Contributor

fisx commented Dec 19, 2024

ac5b68d has passed CI (it's just some signal got lost on the way from concourse to github.)

4c744c8 failed for unrelated reasons, we'll ignore that.

@fisx fisx merged commit 3d700f9 into develop Dec 19, 2024
11 checks passed
@fisx fisx deleted the sventennie/fix-flaky-testMigrationToNewIndex branch December 19, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants