Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration: Use lsof instead of ss to find processes listening on a port #4388

Merged
merged 1 commit into from
Dec 23, 2024
Merged

integration: Use lsof instead of ss to find processes listening on a port #4388

merged 1 commit into from
Dec 23, 2024

Conversation

akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented Dec 23, 2024 •
edited
Loading

Also don't ignore exceptions when stopping dynamic backends.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d No changelog.
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Dec 23, 2024
supersven
supersven approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks useful 👍

@akshaymankar akshaymankar force-pushed the fix-ss-parsing branch 5 times, most recently from d7764c8 to be6e541 Compare December 23, 2024 15:35
@akshaymankar
integration: Use lsof instead of ss to find processes listening on a …
2bef96c 
…port

`ss` prints other processes, but it is not clear why. Using lsof seems to work
better.
@akshaymankar akshaymankar changed the title integration: Print ss output when it doesn't parse integration: Use lsof instead of ss to find processes listening on a port Dec 23, 2024
@akshaymankar akshaymankar merged commit bbd8071 into develop Dec 23, 2024
11 checks passed
@akshaymankar akshaymankar deleted the fix-ss-parsing branch December 23, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supersven supersven supersven approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshaymankar @supersven @zebot