[WPB-15208] kill more flakes #4392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: technical-roadmap/security
zebot
added
the
ok-to-test
fisx
changed the title
This reverts commit 5974b64.
semantic remains the same, but it's more coherent.
fisx
commented
Dec 27, 2024
Comment on lines
+642
to
+650
| assertWebSocketDied :: (HasCallStack) => EventWebSocket -> App () | ||
| assertWebSocketDied ws = do | ||
| recpol <- do | ||
| timeOutSeconds <- asks (.timeOutSeconds) | ||
| pure $ limitRetriesByCumulativeDelay (timeOutSeconds * 1_000_000) (constantDelay 800_000) | ||
| recoverAll recpol $ \_ -> | ||
| assertNoEventHelper ws >>= \case | ||
| NoEvent -> assertFailure $ "WebSocket is still open" | ||
| WebSocketDied -> pure () |
There was a problem hiding this comment.
If we get a NoEvent, and only then a WebSocketDied, the previous version didn't work.
I'm trying magic here. I don't expect it to work, but I'd like to be proven wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-15208
Checklist
changelog.d