Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS support for cannon and background-worker #4410

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Conversation

stefanwire
Copy link
Contributor

https://wearezeta.atlassian.net/browse/WPB-14499

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d no changelog
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. label Jan 14, 2025
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 14, 2025
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

Background-worker doesn't (need to) access the Kubernetes API.
@stefanwire stefanwire merged commit 55dd92c into develop Jan 14, 2025
11 checks passed
@stefanwire stefanwire deleted the sb/tls-support branch January 14, 2025 11:23
akshaymankar added a commit that referenced this pull request Jan 15, 2025
Fixup for #4410

The service account needs to be unset expliclty otherwise the previous value
remains. kubernetes/kubernetes#72519
akshaymankar added a commit that referenced this pull request Jan 15, 2025
Fixup for #4410

The service account needs to be unset expliclty otherwise the previous value
remains. kubernetes/kubernetes#72519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants