WPB-15551 Domain Registration Team Feature #4429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added internal endpoint for setting the lockstatus
echoes-hq
bot
added
the
echoes/initiative: scale
zebot
added
the
ok-to-test
fisx
approved these changes
Jan 28, 2025
| @@ -518,6 +518,18 @@ limitedEventFanout: | |||
| status: disabled | |||
| ``` | |||
|
|
|||
| ### Domain Registration | |||
|
|
|||
| This feature flag is per default disabled and locked. It can be set by `ibis` via the internal API and it is not meant to be configured via team management. | |||
There was a problem hiding this comment.
"set" meaning "changes to enabled / unlocked"? or does the team admin have to enable it?
There was a problem hiding this comment.
It can be dis/-enabled and (un-)locked by ibis. Team admin cannot change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-15551
This is a standalone PR that just adds the team feature. Integrating this into the domain registration flow will be a follow up.
Checklist
changelog.d