Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 503 on team invitation with wire-server-enterprise disabled #4439

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Fix 503 on team invitation with wire-server-enterprise disabled #4439

merged 2 commits into from
Feb 3, 2025

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Feb 3, 2025 •
edited
Loading

Followup to #4418.

The test that user registration and team invitation works with enterprise login disabled was accidentally deleted. This re-enables the test and fixes the 503 in that case by making GetDomainRegistration return Nothing in the Null interpreter.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 3, 2025
supersven
supersven approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pcapriotti pcapriotti merged commit b3b37a9 into develop Feb 3, 2025
11 checks passed
@pcapriotti pcapriotti deleted the fix-503-again branch February 3, 2025 12:40
@zebot zebot mentioned this pull request Feb 7, 2025
Merged
@echoes-hq echoes-hq bot added the echoes/initiative: scale Enterprise Readiness Initiatives label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@battermann battermann battermann approved these changes

@supersven supersven supersven approved these changes

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
echoes/initiative: scale Enterprise Readiness Initiatives ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pcapriotti @battermann @supersven @fisx @zebot