Feature/suspend team #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschaul
force-pushed
the
feature/suspend-team
branch
2 times, most recently
from
a8e2a77 to
1d18a7c
Compare
jschaul
force-pushed
the
feature/suspend-team
branch
from
1d18a7c to
fc1ce7c
Compare
Adds two internal endpoints on brig * /i/teams/:tid/suspend * suspends accounts of all users of a given (binding) team * deletes all existing team invitations * /i/teams/:tid/unsuspend * reactivates all user accounts of a given (binding) team. * Team invitations are _not_ restored and need to be sent out again.
jschaul
force-pushed
the
feature/suspend-team
branch
from
fc1ce7c to
b36f432
Compare
services/brig/src/Brig/Team/API.hs
Outdated
| let iids = inInvitation <$> DB.resultList page | ||
| void $ liftIO $ mapConcurrently (del e) iids | ||
| when (DB.resultHasMore page) $ | ||
| lift (DB.lookupInvitations tid (Just $ last iids) (unsafeRange 100)) >>= deleteInvitations |
There was a problem hiding this comment.
last could eventually raise an exception if the list is empty; we can just paginate using nextPage like is done here
services/brig/src/Brig/Team/API.hs
Outdated
| deleteInvitations page = do | ||
| e <- ask | ||
| let iids = inInvitation <$> DB.resultList page | ||
| void $ liftIO $ mapConcurrently (del e) iids |
There was a problem hiding this comment.
Could also use mapConcurrently_ here
tiago-loureiro
suggested changes
Aug 16, 2017
tiago-loureiro
approved these changes
Aug 21, 2017
tiago-loureiro
force-pushed
the
feature/suspend-team
branch
from
9223e64 to
0a03bfc
Compare
tiago-loureiro
approved these changes
Aug 22, 2017
flokli
pushed a commit
that referenced
this pull request
Jul 1, 2020
* Add test * Make 'active' field patchable * Make tests marginally more generic. Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two internal endpoints on brig
/i/teams/:tid/suspend- suspends accounts of all users of a given (binding) team, deletes all existing team invitations/i/teams/:tid/unsuspend- reactivates all user accounts of a given (binding) team. Team invitations are not restored and need to be sent out again.