Change of team permission semantics

[fisx]

No description provided.

[fisx]

@tiago-loureiro what did I miss? I am planning to write one integration test for updateConversation that fails for an external member, would you like to see any other tests?

[fisx]

CI doesn't give me the log of the failed test run. Integration tests pass locally for me.

[jschaul]

CI doesn't give me the log of the failed test run.

here it is:

(galley)

  add new team member internal:                                FAIL (0.22s)
      test/integration/API/Teams.hs:250:
      billing users
      expected: ["\STX\167\235B%N@r\135\&4\240~\SOH\STX\"#"]
       but got: ["\253\\\136\USA@LG\128\176\&7\204\181}0;","\STX\167\235B%N@r\135\&4\240~\SOH\STX\"#"]

[fisx]

thanks! this happens locally:

    add new team member internal:                                OK (0.13s)

i guess i need to run the real aws tests...

[fisx]

I am somewhat hopeful that I have made the test pass, but I'm not sure it's still consistent with the intended meaning?

[fisx]

Possible further test cases:

• testUpdateTeamConv, but with creating a non-team conversation
• corresponding tests for updateConversationAccess, updateConversationReceiptMode, updateConversationMessageTimer.

Should I...? (Preferably in a separate PR.)

[fisx]

    update conversation as member:                               FAIL (0.17s)
      test/integration/API/Teams.hs:507:
      status
      expected: 200
       but got: 403

[fisx]

I may have forgotten these:

• Open/close to guests? (where do i find that?)
• Create/remove link? (is this POST /conversations/{cnv}/code?)

[jschaul]

Open/close to guests? (where do i find that?)

See

wire-server/libs/galley-types/src/Galley/Types.hs

Lines 115 to 133 in e9ea65f

	-- | Access define how users can join conversations
	data Access
	= PrivateAccess -- ^ Made obsolete by PrivateAccessRole
	| InviteAccess -- ^ User A can add User B
	| LinkAccess -- ^ User can join knowing conversation id
	| CodeAccess -- ^ User can join knowing [changeable/revokable] code
	deriving (Eq, Ord, Show)
	-- | AccessRoles define who can join conversations. The roles are
	-- "supersets", i.e. Activated includes Team and NonActivated includes
	-- Activated.
	data AccessRole
	= PrivateAccessRole -- ^ Nobody can be invited to this conversation
	-- (e.g. it's a 1:1 conversation)
	| TeamAccessRole -- ^ Team-only conversation
	| ActivatedAccessRole -- ^ Conversation for users who have activated
	-- email or phone
	| NonActivatedAccessRole -- ^ No checks
	deriving (Eq, Ord, Show)

- it's part of the conversation metadata.

Create/remove link? (is this POST /conversations/{cnv}/code?)

yes. But being able to add/remove conversation codes are tied to the access mode of the conversation itself though, not to the person doing the request.