Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the connections doc, add haddocks #695

Merged
merged 2 commits into from
Mar 29, 2019
Merged

Move the connections doc, add haddocks #695

merged 2 commits into from
Mar 29, 2019

Conversation

neongreen
Copy link
Contributor

No description provided.

@neongreen
Copy link
Contributor Author

Not very sure that Message is actually unused by all clients

@tiago-loureiro
Copy link
Contributor

Not very sure that Message is actually unused by all clients

Some clients actually do send it but we have hidden it anyway in the UI for a while since it works as a nice source of spam.

We can (and should) remove this at some point, perhaps adding a TODO in this PR?

Copy link
Contributor

@tiago-loureiro tiago-loureiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description change wrt connections is 👍

@neongreen neongreen merged commit 3cd8cce into develop Mar 29, 2019
@neongreen neongreen deleted the doc-connection branch March 29, 2019 15:43
@ChrisPenner ChrisPenner mentioned this pull request Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants