-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix docker images to work with cql-io-1.1.0 #697
Conversation
this is not working yet,
with
|
Shouldn't it use the system-wide GHC? |
@@ -14,6 +14,9 @@ WORKDIR / | |||
# | |||
# Finally, we build docs for haskell-src-exts without hyperlinking enabled | |||
# to avoid a Haddock segfault. See https://github.com/haskell/haddock/issues/928 | |||
# | |||
# Note: git, ncurses, sed are added here for historical reasons; since | |||
# roughly 2019-03-28, they are included in prebuilder as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they are in the prebuilder, why not remove them from here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only so that builder will work with old prebuilder, until everything has been updated. (the point of builder is that it doesn't have to rebuild prebuilder every time it's built, right?)
I checked and the commit of Stack that you're using can be built just fine with
The |
I figured it out myself before reading this, but thought that 6.4.4 won't allow for the 6.4.3 we have installed, and added a sed line. If you say it's not needed I will remove that. Thanks! |
I tried it locally and it worked, so I'd say it can be removed. |
bf243f0
to
cfedd53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works,
This reverts commit cfedd53.
I tried Now it should be ok, I built both docker images successfully. |
No description provided.