New feature flags backend (part 2)

[fisx]

Replaces #817 (which was broken by github).

migration plan

• merge New feature flags backend #813.
  • this will create the new team_features table, but not use it for legalhold.
  • all teams with sso configured will continue working normally, but report as "sso disabled". (weird, yes. sorry.)
• migrate data:
  • for every team that has an idp, set the "sso enabled" flag in galley, in the new table.
  • we'll let legalhold break on all existing teams that have it enabled (not newly created ones).
• merge [WIP] New feature flags backend (part 2) #817
  • switch legalhold feature flag lookup and update from old to new table.
  • this also breaks legalhold.
• yet another PR:
  • this will remove the old legalhold feature flag table.

tasks

• make "put /i/sso-disabled" fail with an explanation why implementing this is hard.
• write (and run) migration script for SSO flag. (frontend depends on this to be sound.)

[tiago-loureiro]

Small nitpicks, check mainly the comments/thoughts on adding the migration on this PR.

[fisx]

Migration works. I will push another commit soon that irons out a few wrinkles. Here is the log from staging:

spar> select team, idp from spar.idp where team=cf0e5a44-257a-4640-ae3a-b0e9e4fe24e3 allow filtering;

 team                                 | idp
--------------------------------------+--------------------------------------
 cf0e5a44-257a-4640-ae3a-b0e9e4fe24e3 | e64ed7f7-8814-4155-ac83-d3b07f947401

galley> select * from galley.team_features where team_id=cf0e5a44-257a-4640-ae3a-b0e9e4fe24e3 ;

 team_id                              | legalhold_status | sso_status
--------------------------------------+------------------+------------
 cf0e5a44-257a-4640-ae3a-b0e9e4fe24e3 |             null |          0

export GALLEY_HOST=...
export GALLEY_KEYSPACE=...
export SPAR_HOST=...
export SPAR_KEYSPACE=...

ssh -v -f ubuntu@${GALLEY_HOST} -L 2021:${GALLEY_HOST}:9042 -N
ssh -v -f ubuntu@${SPAR_HOST} -L 2022:${SPAR_HOST}:9042 -N

./dist/migrate-sso-feature-flag --cassandra-host-galley=localhost --cassandra-port-galley=2021 --cassandra-keyspace-galley=${GALLEY_KEYSPACE} --cassandra-host-spar=localhost --cassandra-port-spar=2022 --cassandra-keyspace-spar=${SPAR_KEYSPACE}
D, Connecting to ::1:2022
I, New control connection: eu-west:1a:::1:2022#12
D, Connecting to ::1:2021
::1 port 41206 to ::1 port 2021, nchannels 4
D, Connection established: eu-west:1a:::1:2022#14
D, Connection established: eu-west:1a:::1:2022#17
I, convs=10
D, Connection established: eu-west:1a:::1:2021#15
I, convs=20
I, convs=30
I, convs=40
I, convs=50
[...]
I, convs=3570
I, convs=3580
I, convs=3590
I, convs=3600
I, convs=3610
I, convs=3620
I, convs=3630
I, convs=3640
I, convs=3650
I, convs=3660
I, convs=3670
I, convs=3680
I, convs=3690
I, convs=3700
I, convs=3710
I, convs=3720

$ echo $?
0

galley> select * from galley.team_features where team_id=cf0e5a44-257a-4640-ae3a-b0e9e4fe24e3 ;

 team_id                              | legalhold_status | sso_status
--------------------------------------+------------------+------------
 cf0e5a44-257a-4640-ae3a-b0e9e4fe24e3 |             null |          1