Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup of deprecated code #894

Merged
merged 1 commit into from
Nov 5, 2019
Merged

cleanup of deprecated code #894

merged 1 commit into from
Nov 5, 2019

Conversation

jschaul
Copy link
Member

@jschaul jschaul commented Oct 30, 2019

No description provided.

@q3k q3k self-requested a review November 5, 2019 11:08
q3k
q3k previously requested changes Nov 5, 2019
View reviewed changes
Copy link

@q3k q3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (CI is green so the cleanup looks sane). However, could you change that commit title to be a bit more descriptive?

@jschaul jschaul force-pushed the feature/remove-dead-endpoint branch from bd6a431 to 7a6c114 Compare November 5, 2019 11:34
@jschaul jschaul merged commit 2f314e6 into develop Nov 5, 2019
@jschaul jschaul deleted the feature/remove-dead-endpoint branch November 5, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiago-loureiro tiago-loureiro tiago-loureiro approved these changes

@q3k q3k q3k left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jschaul @q3k @tiago-loureiro