Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate more CPP #987

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Eliminate more CPP #987

merged 2 commits into from
Feb 21, 2020

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Feb 21, 2020

see commit messages for details.

fisx added 2 commits February 21, 2020 11:26
This is a noisy commit since I ran ormolu right away, but you only
need to know that the packages have more dependencies now even if the
flags are turned off, and that CPP is not enabled any more in all
modules that have been changed.  this is the only change.

This is a good change independently of ormolu, because turning off the
flags wasn't tested anywhere and didn't quite work anyway.
Copy link
Contributor

@mheinzel mheinzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me.

@fisx fisx merged commit fbfb428 into develop Feb 21, 2020
@fisx fisx deleted the fisx/cleanup-149 branch February 21, 2020 14:30
@fisx fisx mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants