Compile nginx with libzauth using nix #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arianvp
commented
Feb 25, 2020
Noteworthy: both vts and moreheaders are packaged in nixpkgs, so no need to fetch those git submodules... but perhaps there are version conflicts. we should check! :) I also use niv for version management of nixpkgs. instead of hacky own thing.
It's in the top-level gitignore of wire-server, but not in the one in libzauth This is all a bit confusing. We should unify everything in one top-level gitignore. That makes things a lot less complicated. However, this is an impurity to tackle in another commit
fisx
reviewed
Mar 3, 2020
There was a problem hiding this comment.
So, i changed libs/libzauth/libzauth-c/src/zauth.h and tried
nix-build nix -A nginz --no-out-linkand it actually re-built nginz. cool.
I would have expected this line to do the same thing, hough, and it doesn't. If I change zauth.h to something new again and call make i on project root, no build is triggered.
|
I probably didn't set this variable. Will investigate later. |
fisx
approved these changes
Mar 3, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to use nginz on Nix and NixOS machines
Noteworthy:
both vts and moreheaders are packaged in nixpkgs, so no need
to fetch those git submodules... I don't think it's a very big problem. We can pin them but it seems to be working fine for now...
I also use niv for version management of nixpkgs. instead of hacky own
thing.
To build this with the newly set up binary cache, try this: