Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert "chore: Publish [skip ci]" #6450

Merged
merged 1 commit into from
Aug 12, 2024
Merged

fix: Revert "chore: Publish [skip ci]" #6450

merged 1 commit into from
Aug 12, 2024

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented Aug 12, 2024

This reverts commit dcbe8d6.

The latest publish commit didn't result in the packages actually being deployed on npm.

Using fix as the commit identifier will make sure the pipeline will publish the packages correctly (chore commits do not get published)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@V-Gira V-Gira merged commit a822cc9 into main Aug 12, 2024
6 checks passed
@V-Gira V-Gira deleted the v/publish-fix branch August 12, 2024 12:21
@paulwire paulwire added the echoes: bugs Technical or functional defects in the product label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisamir98 thisisamir98 thisisamir98 approved these changes

Assignees
No one assigned
Labels
echoes: bugs Technical or functional defects in the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@V-Gira @thisisamir98 @paulwire