Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Monorepo #17159

Draft
wants to merge 55 commits into
base: dev
Choose a base branch
from
Draft

chore: Monorepo #17159

wants to merge 55 commits into from

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Mar 25, 2024

This is a first step into having a monorepo structure for all our apps and packages.

The long run idea is to have

in the same repo along with the custom packages they all consume.

Scope

This first step will:

  • use only yarn as the monorepo manager
  • only move the webapp to the monorepo (libraries will be added in a follow up PR)
  • make sure CI and deploy jobs work fine with the new structure

What is not included in this iteration:

  • caching (a high level library like turborepo/lerna/nx/bit... will be included later)
  • migrating libraries to the monorepo
  • migrating other end-user apps to the monorepo

TODO

  •  restore deployment script
  • restore wire-builds repository update
  • make sure dependabot config is still working with the new setup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this plugin is now included with yarn 4.0.1

Comment on lines 1 to 5
{
"*": "prettier --ignore-unknown --write",
"*.less": ["stylelint --fix"],
"*.{js,jsx,ts,tsx}": ["eslint --fix"]
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.19%. Comparing base (5ffe37a) to head (f271322).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #17159      +/-   ##
==========================================
+ Coverage   46.02%   47.19%   +1.16%     
==========================================
  Files         746     1010     +264     
  Lines       24556    29849    +5293     
  Branches     5618     6274     +656     
==========================================
+ Hits        11303    14086    +2783     
- Misses      11823    14269    +2446     
- Partials     1430     1494      +64     

@atomrc atomrc marked this pull request as ready for review March 28, 2024 14:29
@atomrc atomrc requested review from otto-the-bot and a team as code owners March 28, 2024 14:29
@atomrc atomrc marked this pull request as draft April 2, 2024 13:01
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.24%. Comparing base (7fe2553) to head (8cd556a).

Current head 8cd556a differs from pull request most recent head 0296a12

Please upload reports for the commit 0296a12 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #17159      +/-   ##
==========================================
+ Coverage   46.31%   47.24%   +0.92%     
==========================================
  Files         758     1011     +253     
  Lines       24904    29904    +5000     
  Branches     5714     6281     +567     
==========================================
+ Hits        11535    14129    +2594     
- Misses      11928    14284    +2356     
- Partials     1441     1491      +50     

Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
1589 New issues
0 Accepted issues

Measures
145 Security Hotspots
No data about Coverage
1.5% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
1617 New issues
0 Accepted issues

Measures
145 Security Hotspots
No data about Coverage
1.5% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants