fix: Minimized calling cell #17697
Open
fix: Minimized calling cell #17697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
e-maad
reviewed
Aug 7, 2024
| @@ -366,8 +350,7 @@ const Conversations: React.FC<ConversationsProps> = ({ | |||
| /> | |||
| )} | |||
|
|
|||
| {((showSearchInput && currentTabConversations.length === 0) || | |||
| (hasNoConversations && currentTab !== SidebarTabs.ARCHIVES)) && ( | |||
| {((showSearchInput && currentTabConversations.length === 0) || hasNoConversations) && ( | |||
There was a problem hiding this comment.
As you are touching this part of code, I would suggest to remove === 0
echoes-hq
bot
added
the
echoes: features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-9782
Description
Improved calling view. Calling view has been moved to the bottom and styles has been refactored to avoid usage styles from conversation list cell.
Screenshots/Screencast (for UI changes)
Before:
Not detached window:
Detached window:
After:
Not detached window:
Detached window:
Checklist
Important details for the reviewers
(Delete this section if unnecessary)