-
Notifications
You must be signed in to change notification settings - Fork 296
chore: blocking user spec [19940] #19784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds regression tests for user blocking functionality across 8 test scenarios, along with some folder management tests. The implementation includes new helper functions, page objects, and modal classes to support the test automation.
Key Changes
- Added 7 blocking-related test cases covering various scenarios (blocking/unblocking users in different team configurations)
- Created reusable helper functions for common user actions (login, connection, blocking)
- Added new page object methods and modal classes to support blocking and folder functionality
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e_tests/utils/userActions.ts | Added helper functions for login, manual connection, and blocking users from various UI locations; contains async/await bugs |
| test/e2e_tests/specs/Block/block.spec.ts | Main blocking test suite with 7 test cases; contains logic bugs and naming issues |
| test/e2e_tests/specs/Block/block2.spec.ts | Appears to be a misplaced development/debug file not related to blocking |
| test/e2e_tests/specs/Folders/Folders.spec.ts | Folder management tests; contains test logic bug |
| test/e2e_tests/pageManager/webapp/pages/conversationList.page.ts | Added locators and methods for blocking UI elements |
| test/e2e_tests/pageManager/webapp/pages/conversationDetails.page.ts | Added block conversation button locator and click method |
| test/e2e_tests/pageManager/webapp/pages/account.page.ts | Added team name locator |
| test/e2e_tests/pageManager/webapp/modals/userProfile.modal.ts | Added unblock button locator |
| test/e2e_tests/pageManager/webapp/modals/unblockWarning.modal.ts | New modal class for unblock confirmation; contains naming inconsistency |
| test/e2e_tests/pageManager/webapp/modals/createNewFolder.modal.ts | New modal class for creating folders |
| test/e2e_tests/pageManager/webapp/modals/conversationNotConnected.modal.ts | New modal class for connection errors |
| test/e2e_tests/pageManager/webapp/components/conversationSidebar.component.ts | Added folder navigation methods |
| test/e2e_tests/pageManager/index.ts | Registered new modal classes in page manager |
test/e2e_tests/pageManager/webapp/modals/conversationNotConnected.modal.ts
Outdated
Show resolved
Hide resolved
test/e2e_tests/pageManager/webapp/modals/createNewFolder.modal.ts
Outdated
Show resolved
Hide resolved
test/e2e_tests/pageManager/webapp/modals/unblockWarning.modal.ts
Outdated
Show resolved
Hide resolved
test/e2e_tests/pageManager/webapp/pages/conversationList.page.ts
Outdated
Show resolved
Hide resolved
dfceac3 to
afb4a73
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #19784 +/- ##
==========================================
- Coverage 43.45% 43.44% -0.01%
==========================================
Files 1294 1294
Lines 32544 32544
Branches 7230 7230
==========================================
- Hits 14141 14140 -1
Misses 16691 16691
- Partials 1712 1713 +1 🚀 New features to boost your workflow:
|
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
Failed Tests:❌ Account Management (tags: TC-8639, crit-flow-web)Location: specs/CriticalFlow/accountManagement-TC-8639.spec.ts:37 Errors: ❌ Planning group call with sending various messages during call (tags: TC-8632, crit-flow-web)Location: specs/CriticalFlow/groupCalls-TC-8632.spec.ts:37 Errors: ❌ Group Video call (tags: TC-8637, crit-flow-web)Location: specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:39 Errors: ❌ New person joins team and setups up device (tags: TC-8635, crit-flow-web)Location: specs/CriticalFlow/joinTeam-TC-8635.spec.ts:38 Errors: Flaky Tests: |
add function to userActions.ts to send a connection request add fixture for connection request delete conversationNotConnected.modal.ts, replace it with acknowledge.modal.ts
|


Description
Add regression tests for blocking users in eight cases
Checklist