Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple Screenshots #183

Merged
merged 26 commits into from
Mar 2, 2022
Merged

Multiple Screenshots #183

merged 26 commits into from
Mar 2, 2022

Conversation

passsy
Copy link
Member

@passsy passsy commented Feb 22, 2022 •
edited
Loading

Allows adding of multiple screenshots

Screen-Shot-2022-02-22-21-36-12 48

Technical details

This change required an API change and major adjustments of the persistence layer. All pending feedback with the old data model will be dropped.

Other changes

  • pending Feedback is now submitted 5s after app start, not immediately

Requirements

  • Deploy new uploadAttachment endpoint to prod

passsy added 26 commits February 10, 2022 23:13
@passsy
Let DirectFeedbackSubmitter submit multiple attachments
39c0be6
@passsy
Implement new attachment API
784cca3
@passsy
Test feedback storage
a488769
@passsy
Submit feedback right away and return if it worked or not
8b21425
@passsy
RetryingFeedbackSubmitter does not crash when screenshot file does no…
3dcc99c 
…t exist
@passsy
submitPendingFeedbackItems awaits currently running submission loop
3403aa3
@passsy
Use filesystem everywhere (remove dart:io)
0585ace
@passsy
Validate attachment length
02545de
@passsy
Allow multiple screenshots
8d708b8
@passsy
Submit pending feedbacks delayed
31c8abe
@passsy
Improve WiredashApiException.toString()
da63ab2
@passsy
Merge branch 'stable' into multiple_attachments
bf9e939
@passsy
Rename DeviceInfo -> FlutterDeviceInfo
c1cd65f 
It better represents where the data is coming from
@passsy
Sort properties alphabetically
9c28447
@passsy
Cleanup
eefde53
@passsy
Test partially submission
3f4d6bb
@passsy
Test exponential backoff
a7b6ad9
@passsy
Do not retry for UnauthenticatedWiredashApiException
401089b
@passsy
Submit shouldn't throw when having items as pending
ec0e08f 
Show some errors now even when not on desktop environments
@passsy
Execute submitPendingFeedbackItems after successful submit()
bacd578
@passsy
Fix platformBrightness property
8162ffc
@passsy
Remove platformBrightess from feedback body
69fcea2
@passsy
Parse official error format
23ccb11
@passsy
Make errorCode int
dc4127b
@passsy
Switch back to prod
8ade235
@passsy
Move all properties back to from attachment to feedback
8794238
@passsy passsy merged commit c8740b2 into stable Mar 2, 2022
@passsy passsy deleted the multiple_attachments branch March 2, 2022 15:14
@RibuRoyson RibuRoyson mentioned this pull request Mar 8, 2024
Closed
@ribuemsyne ribuemsyne mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@passsy