-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework automatic theming #205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automatic theming of Wiredash (using
Wiredash.of(context).show(inheritMaterialTheme: true)
) has been reworked. It worked for the most part, but some colors did not generate good secondary colors and colors like theappHandleBackgroundColor
were not customizable.The new auto-theme uses the
material_color_utilities
under the hood, which uses an interesting color space to generate matching color tones in different shades, exactly what Wiredash needed. More on this on https://m3.material.io/styles/color/dynamic-color/overviewIt also adds new custom colors:
primaryContainerColor
textOnPrimaryContainerColor
(replacesprimaryTextColor
)secondaryContainerColor
textOnSecondaryContainerColor
(replacessecondaryTextColor
)appBackgroundColor
appHandleBackgroundColor
To test the whole thing I created a Theme customizer
example/lib/main_customizer.dart
to test out different colors in light and dark mode. That's not the final design, but functional.