Keeps the SyncEngine alive when the Wiredash widget updates #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SyncEngine (or better their jobs) depends on the WiredashApi. The WiredashApi depends on the Wiredash widget. When the Wiredash widget changes -because the secret or the projectId have might have changed - the WiredashApi gets recreated and so does the SyncEngine. Unfortunately, this cancels the inital sync where the engine waits 5s before firing the first jobs. This fix makes sure the SyncEngine does not get recreated. It uses the same instance as long as Wiredash lives. Why wasn't this caught with tests? Well it was tested. But in tests there is no dependency from the MockWireadshApi to the Wiredash Widget, thus not causing a rebuild. Sigh...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SyncEngine (or better their jobs) depends on the WiredashApi. The WiredashApi depends on the Wiredash widget. When the Wiredash widget changes -because the secret or the projectId have might have changed - the WiredashApi gets recreated and so does the SyncEngine. Unfortunately, this cancels the inital sync where the engine waits 5s before firing the first jobs.
This fix makes sure the SyncEngine does not get recreated. It uses the same instance as long as Wiredash lives.
Why wasn't this caught with tests? Well it was tested. But in tests there is no dependency from the MockWireadshApi to the Wiredash Widget, thus not causing a rebuild. Sigh...