Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WT-13442 Do not allow out of order truncate commit timestamp #11012

Merged
merged 7 commits into from
Sep 18, 2024

Conversation

kommiharibabu
Copy link
Contributor

@kommiharibabu kommiharibabu commented Sep 6, 2024

WiredTiger doesn't allow out of order commit timestamp and it return an error whenever an operation is trying to commit with a timestamp less than the existing timestamp on an update. But it missed to verify the truncate commit timestamp.

The WiredTiger timestamp usage check is extended for the truncate operations also doesn't allow an out of order commit timestamp to be performed.

WiredTiger doesn't allow out of order commit timestamp and it
return an error whenever an operation is trying to commit with
a timestamp less than the existing timestamp on an update.
But it missed to verify the truncate commit timestamp.

The WiredTiger timestamp usage check is extended for the truncate
operations also doesn't allow an out of order commit timestamp
to be performed.
@kommiharibabu kommiharibabu marked this pull request as draft September 6, 2024 03:36
Copy link

github-actions bot commented Sep 6, 2024

Thanks for creating a pull request! The below questions and checklist are intended to help with verifying your change is well tested. Response is optional, but if you choose to respond please edit this comment.

What makes this change safe?

A good answer to this question helps the reviewers understand where they should focus their attention, so please consider these questions:

  • Is the change risky or not? Why?
  • What tests are you adding or changing? Why?
  • What existing tests are you relying on?
  • What, if anything, are you concerned about that you'd like the reviewer to focus on?
    References:
  • Risk level guide
  • Testing frameworks

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation (if applicable).
  • I have added/updated tests that demonstrate my fix is effective or that my feature works correctly.

@kommiharibabu kommiharibabu marked this pull request as ready for review September 9, 2024 03:59
src/include/btree.h Outdated Show resolved Hide resolved
src/include/txn_inline.h Outdated Show resolved Hide resolved
Copy link
Contributor

@Sean04 Sean04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kommiharibabu kommiharibabu added this pull request to the merge queue Sep 18, 2024
Merged via the queue into develop with commit 2a2b22d Sep 18, 2024
10 checks passed
@kommiharibabu kommiharibabu deleted the wt-13442-truncate-ooo-timestamp branch September 18, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants