-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WT-13442 Do not allow out of order truncate commit timestamp #11012
Conversation
WiredTiger doesn't allow out of order commit timestamp and it return an error whenever an operation is trying to commit with a timestamp less than the existing timestamp on an update. But it missed to verify the truncate commit timestamp. The WiredTiger timestamp usage check is extended for the truncate operations also doesn't allow an out of order commit timestamp to be performed.
Thanks for creating a pull request! The below questions and checklist are intended to help with verifying your change is well tested. Response is optional, but if you choose to respond please edit this comment. What makes this change safe?A good answer to this question helps the reviewers understand where they should focus their attention, so please consider these questions:
Checklist before requesting a review
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WiredTiger doesn't allow out of order commit timestamp and it return an error whenever an operation is trying to commit with a timestamp less than the existing timestamp on an update. But it missed to verify the truncate commit timestamp.
The WiredTiger timestamp usage check is extended for the truncate operations also doesn't allow an out of order commit timestamp to be performed.