Update to modern python tooling #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modern python has standardisde around poetry for dependency management. Before starting to develop new features I wanted to set a baseline python version at python 3.7. Alongside this migration to poetry for dependency management, I have also migrated all of the test suite to pytest. I did this mostly as a way to really get some good exposure on the code base via the tests but to also modernise the testing tooling in use. github action support has also been added as that will be used for the CI pipeline going forward which will run this new test suite.
|
FYI @platinummonkey . Would you be fine if we go ahead with merging and declaring @mikeywaites as a co-maintainer officially? |
platinummonkey
approved these changes
Apr 23, 2023
This was referenced Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern python has standardisde around poetry for dependency management. Before starting to develop new features I wanted to set a baseline python version at python 3.7.
Alongside this migration to poetry for dependency management, I have also migrated all of the test suite to pytest. I did this mostly as a way to really get some good exposure on the code base via the tests but to also modernise the testing tooling in use.
github action support has also been added as that will be used for the CI pipeline going forward which will run this new test suite.