-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testcontainers Support in WireMock Python #72
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d6297b
to
94f0d7d
Compare
94f0d7d
to
4634c10
Compare
This is a WIP
checking the code in at this point. extensions are causing the container to crash.
remove the docker in docker config variable as this will be a user managed configurations. increased test coverage after some additional api tweaks were made to the test container
Added handling to the server_running method to support cases where the docker container is running testcontainers inside a container. When this flow is used users will need to set an WIREMOCK_DIND env var so that the host used can revert to the host.docker.internal url. There are also a number of fixes to the code to get the test suites passing. Test run time was all reduced significantly by mocking more method to avoid starting containers on a test by test bases.
f01ff72
to
6b4b1fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming needs cleanup across the board in the docs. For example, it is a part of [not so documented] certification criteria. Have not got to testing the guidelines and full review yet
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Adds support for testcontainers-python. Now you can programmatically spin up a
WireMockContainer
directly from your test suite. WireMockContainer ships with support for auto generating mapping and stub files, easily manage the container life cycle with thewiremock_container
context manager, integrates easily into your existing test suite, supports docker in docker mode for common CI use cases and much more.Submitter checklist