Implementing testcontainers in Node.js #1
Conversation
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
Thanks! I think the next step would be to actually introduce a small module library, which for example adds the withMapping() method, and to move the current example to demos that uses this module
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
It still needs to be properly structured so that there is actually an NPM module with proper namespaces, metadata, etc
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
Looks good! Just a few minor suggestions, and it is ready to go IMHO
package.json
Outdated
| { | ||
| "name": "wiremock-testcontainers-node", | ||
| "version": "0.0.1", | ||
| "description": "Run wiremock tests using testcontainers in node.js", |
There was a problem hiding this comment.
| "description": "Run wiremock tests using testcontainers in node.js", | |
| "description": "Run WireMock if your Javascript/Typescript tests using Testcontainers for Node.js", |
package.json
Outdated
| "test": "node demo.js" | ||
| }, | ||
| "author": "Aditya Ghidora", | ||
| "license": "MIT" |
There was a problem hiding this comment.
I suggest adding a LICENSE file too, Note that WireMock uses the Apache License v2, and I suggest sticking to it unless you have a strong opinion
README.md
Outdated
| @@ -1,2 +1,27 @@ | |||
| # wiremock-testcontainers-node | |||
|
|
|||
| WireMock module for Testcontainers for NodeJS | |||
There was a problem hiding this comment.
| WireMock module for Testcontainers for NodeJS | |
| WireMock module for [Testcontainers for NodeJS](https://node.testcontainers.org/) |
2 participants
Works on the following issue
wiremock/ecosystem#10
Currently just added a basic hello world test