Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default the max template cache entries to 1000 instead of infinite #2752

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

leeturner
Copy link
Contributor

@leeturner leeturner commented Jun 11, 2024

This PR defaults the max template cache entries to 1000 instead of infinite.

References

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@leeturner leeturner requested a review from a team as a code owner June 11, 2024 13:19
@tomakehurst
Copy link
Member

Are we also going to set the default for programmatic startup i.e. in WireMockConfig?

@leeturner
Copy link
Contributor Author

Are we also going to set the default for programmatic startup i.e. in WireMockConfig?

Ah, yes. Missed that 👍

@leeturner leeturner self-assigned this Jun 18, 2024
@leeturner leeturner merged commit f86eeec into master Jun 18, 2024
11 checks passed
@leeturner leeturner deleted the set-default-for-max-template-cache branch June 18, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants