Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add authentication and HTTPS #684
base: master
Are you sure you want to change the base?
Add authentication and HTTPS #684
Changes from 2 commits
4613601
a51203e
7e8a0c0
1af0d64
236d89c
2cbbac6
a0a2288
645bed2
4dac73b
d29caa0
f30dc8b
42dabe4
8c2840c
4a34fef
fcb4140
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
мне кажется, что тут обязательно проверить, что это тот же контроллер. А то может это другой ответил, или captive portal какой-нибудь, или просто клиент пробросил 80 порт, а на 443 у него какая-нибудь админка роутера.
Я к тому, что этот check должен что-то возвращать, что подтверждает, что:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Такое точно возможно?
Если ответит другой, то запрос не пройдёт из-за другого домена в сертификате.
Check warning on line 362 in app/scripts/app.js
Codacy Production / Codacy Static Code Analysis
app/scripts/app.js#L362
Check warning on line 384 in app/scripts/app.js
Codacy Production / Codacy Static Code Analysis
app/scripts/app.js#L384
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure '$' Is Defined or Replace With AngularJS Equivalent
The use of
$
at lines 587-588 may cause runtime errors if jQuery is not included or$
is not defined. Consistent with AngularJS best practices, please replace$
withangular.element
, or ensure that jQuery is properly integrated into the project.Apply this change:
🧰 Tools
🪛 eslint
[error] 587-587: '$' is not defined.
(no-undef)
[error] 588-588: '$' is not defined.
(no-undef)