Add "protocol:" prefix to type in config/Load

[KraPete]

config/Load RPC response contains a list of device templates. Each template item has type field with value from templates' s device_type. Protocols for custom devices are also in the list. Type field for them is populated with a protocol name. The type field must be unique across all items, but some device types and protocol names are the same. Add prefix to protocol types to make them unique

При запросе списка доступных шаблонов устройств, возвращаются в этом же списке и схемы для произвольных йстройств с заданным протоколом. Для каждого элемента в этом списке есть поле type, которое является ключём. Потом по этому полю можно запросить схему для json-editor. Для произвольных устройств туда пишется название протокола. Оказалось, что тип устройства в шаблоне и протокол могут совпадать. В результатет поле type не уникальное. Для протоколов добавил префикс в поле type

Summary by CodeRabbit

• New Features

  • Added a "protocol:" prefix to the type field in configuration responses for custom devices, improving compatibility with Mercury 230 configurations in the interface.

• Bug Fixes

  • Updated compatibility requirements for the wb-mqtt-homeui package to ensure proper functionality with the latest version of wb-mqtt-serial.

• Enhancements

  • Improved handling of protocol types in JSON responses, streamlining the schema retrieval process.

[coderabbitai]

Warning

Rate limit exceeded

@KraPete has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 32 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 12fa14c and e37a7c3.

📒 Files selected for processing (1)

• debian/changelog (1 hunks)

Walkthrough

The pull request introduces updates to the wb-mqtt-serial package, including a new version release (2.151.0) that adds a "protocol:" prefix to the type field in the configuration Load RPC response for custom device schemas. Additionally, the debian/control file is modified to change the compatibility requirements for the wb-mqtt-homeui package. The changes also enhance the handling of protocol types in the rpc_config_handler.cpp file, refining how protocol-related JSON responses are constructed and processed.

Changes

File	Change Summary
debian/changelog	Updated to version 2.151.0; added "protocol:" prefix to type field in Load RPC response for custom device schemas.
debian/control	Updated Breaks field for wb-mqtt-homeui from << 2.82.0~~ to << 2.107.0~~.
src/rpc/rpc_config_handler.cpp	Introduced PROTOCOL_PREFIX, updated MakeProtocolJson and GetSchema methods to handle protocol types correctly.

Possibly related PRs

• Fix reconfiguration of fast modbus events #831: Addresses issues related to device polling after a reboot, relevant to configuration handling for custom devices.
• Add condition to device template setup section #833: Introduces conditions to device template setups, aligning with enhancements in configuration handling for custom devices.
• Fix condition evaluation in device template setup section #834: Fixes condition evaluation in device template setups, directly related to updates on configuration handling for custom devices.

Suggested reviewers

• sikmir

🐰 In the world of code, so bright and new,
A prefix is added, a change to pursue.
With versions updated, the flow’s now refined,
Custom devices, in harmony aligned.
Hopping through logic, with joy we embrace,
The tweaks in our system, a leap in our pace! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.