Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOFT-4770 #126

Merged
merged 1 commit into from
Feb 3, 2025
Merged

SOFT-4770 #126

merged 1 commit into from
Feb 3, 2025

Conversation

ninedev-i
Copy link
Contributor

@ninedev-i ninedev-i commented Jan 30, 2025

Добавил автоматический ресайз для картинок.

Summary by CodeRabbit

  • New Features

    • Enhanced image rendering with responsive design
    • Added support for WebP image format
    • Introduced image presets for preview and original images
    • Implemented responsive image sizing with defined screen breakpoints
  • Improvements

    • Optimized image quality and dimensions
    • Added min and max height constraints for images

@ninedev-i ninedev-i requested a review from a team as a code owner January 30, 2025 12:33
Copy link
Contributor

coderabbitai bot commented Jan 30, 2025

Walkthrough

The pull request introduces improvements to image handling in a Nuxt application. Changes are made to the Photo.vue component and nuxt.config.ts to enhance image rendering and responsiveness. The modifications include switching from NuxtImg to NuxtPicture, adding new image presets, defining screen breakpoints, and implementing CSS constraints for image dimensions. These updates aim to optimize image display across different device sizes and improve overall image quality.

Changes

File Change Summary
components/content/Photo.vue - Replaced NuxtImg with NuxtPicture in #image and #preview slots
- Added preset and sizes attributes to image slots
- Added CSS rule for .photo-image img with min and max height constraints
nuxt.config.ts - Added image configuration section
- Defined WebP as primary image format
- Established screen breakpoints (xs, md, lg, xl)
- Created preview and original image presets with specific width, quality, and format settings

Suggested Reviewers

  • lostpoint-ru

Poem

🐰 Pixels dance, images bright
WebP magic takes its flight
Responsive frames, dimensions tight
From mobile screen to desktop's might
A rabbit's code, a visual delight! 🖼️

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (3)
nuxt.config.ts (1)

54-69: Consider content-specific image presets.

The current presets are good starting points, but consider adding specific presets for different content types:

  • Thumbnails might benefit from lower quality (50-60%) and smaller width
  • Hero images might need higher quality (95-100%)

Example configuration:

 presets: {
   preview: {
     modifiers: {
       width: 800,
       quality: 70,
       format: 'webp',
     }
   },
   original: {
     modifiers: {
       width: 1280,
       quality: 90,
       format: 'webp',
     }
   },
+  thumbnail: {
+    modifiers: {
+      width: 400,
+      quality: 60,
+      format: 'webp',
+    }
+  },
+  hero: {
+    modifiers: {
+      width: 1920,
+      quality: 95,
+      format: 'webp',
+    }
+  }
 }
components/content/Photo.vue (2)

33-40: Enhance responsive image sizing.

The current sizes attribute could be more granular to better match the screen breakpoints defined in the config.

-          sizes="md:100vw"
+          sizes="(max-width: 320px) 100vw, (max-width: 768px) 90vw, (max-width: 1024px) 80vw, 70vw"

Line range hint 1-1: Consider implementing image optimization infrastructure.

To enhance the image handling system, consider:

  1. Implementing a CDN for faster image delivery
  2. Setting up proper cache headers for optimized images
  3. Adding monitoring for image processing performance
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cee1424 and f79993f.

📒 Files selected for processing (2)
  • components/content/Photo.vue (3 hunks)
  • nuxt.config.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (3)
nuxt.config.ts (2)

48-53: LGTM! Well-defined responsive breakpoints.

The screen breakpoints follow common responsive design patterns and align well with standard device sizes.


47-47: Consider adding fallback image formats.

Currently only webp format is specified. While webp offers excellent compression, consider adding fallback formats (like jpeg/png) for broader browser compatibility.

components/content/Photo.vue (1)

Line range hint 50-59: LGTM! Good use of presets for preview vs original.

The separation between preview and original images with different quality presets is a good optimization.

components/content/Photo.vue Show resolved Hide resolved
@ninedev-i ninedev-i merged commit f48785b into main Feb 3, 2025
3 checks passed
@ninedev-i ninedev-i deleted the feature/image-auto-resize branch February 3, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants