C code style format and checks #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the travis pipeline to check violations of the c code standard. It also adds a script to apply the style to any .c or .h file in the project.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
GwendalRaoul
reviewed
May 9, 2019
| &travel_time, | ||
| &qos, | ||
| &hop_count); | ||
| r = sd_bus_message_read( |
There was a problem hiding this comment.
In this case, could you remove clang formatting?
All those parameters are more readable with one on each line
There was a problem hiding this comment.
It actually makes no sense shy the format is being applied like this :(
| { | ||
| int r; | ||
| /* Release the GIL. It will be acquire by the callback | ||
| * It make this thread totally independant from python code | ||
| */ | ||
| Py_BEGIN_ALLOW_THREADS | ||
| for (;;) | ||
| Py_BEGIN_ALLOW_THREADS for (;;) |
There was a problem hiding this comment.
Why is it put on same line?
sink_service/source/data.c
Outdated
| travel_time, | ||
| qos, | ||
| hop_count); | ||
| r = sd_bus_message_append( |
There was a problem hiding this comment.
Same here, it would be better to keep one on each line
sink_service/source/main.c
Outdated
| @@ -84,7 +82,8 @@ int main(int argc, char *argv[]) | |||
| break; | |||
| case 'i': | |||
| /* Get the sink id to generate service name */ | |||
| sink_id = strtoul(optarg, NULL, 0);; | |||
| sink_id = strtoul(optarg, NULL, 0); | |||
| ; | |||
sink_service/source/otap.c
Outdated
| SD_BUS_PROPERTY("ProcessedLen", "u", NULL, offsetof(sink_otap_t, processed_len), 0), | ||
| SD_BUS_PROPERTY("ProcessedCrc", "q", NULL, offsetof(sink_otap_t, processed_crc), 0), | ||
| SD_BUS_PROPERTY("ProcessedSeq", "y", NULL, offsetof(sink_otap_t, processed_seq), 0), | ||
| SD_BUS_PROPERTY("StoredLen", "u", NULL, offsetof(sink_otap_t, stored_len), 0), |
There was a problem hiding this comment.
I prefer the old allignement here
GwendalRaoul
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the travis pipeline to
check violations of the c code standard.
It also adds a script to apply the style to
any .c or .h file in the project.